! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
only warn once about hddtemp setuid stuff
Status:
RESOLVED: FIXED
Product:
Xfce4-sensors-plugin
Component:
General

Comments

Description Yves-Alexis Perez editbugs 2008-06-10 05:37:48 CEST
Hi,

a Debian user requested that sensor plugin would not warn every time about missing setuid stuff for hddtemp. If it's not configured with setuid bit, sensors should warn the fist time, but ignore it completely the following times.

Cheers,

--
Yves-Alexis
Comment 1 Yves-Alexis Perez editbugs 2008-06-26 18:35:32 CEST
And if hddtemp is not present at all, same thing, the plugin could warn once, but only once.
Comment 2 Fabian Nowak editbugs 2008-06-26 21:43:16 CEST
there you go, this also fixed some null pointer problems.
Comment 3 Fabian Nowak editbugs 2009-01-23 20:28:08 CET
Wanna close this one, too?
Comment 4 Harold Aling 2009-01-23 20:47:19 CET
"there you go, this also fixed some null pointer problems."
Comment 5 Yves-Alexis Perez editbugs 2013-05-29 20:59:29 CEST
Seems this one is back (since a few months/years, actually, so reopening).
Comment 6 Raphael Groner 2013-05-30 12:05:55 CEST
(In reply to comment #5)
> Seems this one is back (since a few months/years, actually, so reopening).

You may know that you can build without hddtemp support.  What version do you use? There hasn't been any new source commit since a long time, last: 2012-12-28 20:51:53 (GMT).
Comment 7 Yves-Alexis Perez editbugs 2013-05-30 21:42:39 CEST
(In reply to comment #6)
> (In reply to comment #5)
> > Seems this one is back (since a few months/years, actually, so reopening).
> 
> You may know that you can build without hddtemp support.

I know. We build for all the distribution users, not only one people, so we do enable it at build time. What we need is a way to have it disabled at runtime. 

Exactly what this bug report was about. The fix was committed, but there was a regression somehow at one point.

>  What version do
> you use? There hasn't been any new source commit since a long time, last:
> 2012-12-28 20:51:53 (GMT).

1.2.5.
Comment 8 Fabian Nowak editbugs 2014-05-01 11:20:09 CEST
(In reply to Yves-Alexis Perez from comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Seems this one is back (since a few months/years, actually, so reopening).
> > 
> > You may know that you can build without hddtemp support.
> 
> I know. We build for all the distribution users, not only one people, so we
> do enable it at build time. What we need is a way to have it disabled at
> runtime. 
> 
> Exactly what this bug report was about. The fix was committed, but there was
> a regression somehow at one point.
> 
> >  What version do
> > you use? There hasn't been any new source commit since a long time, last:
> > 2012-12-28 20:51:53 (GMT).
> 
> 1.2.5.

OK, what "warnings" are found? The current code intendedly alwys showed the notifications, but it was possible to shutdown the warnings dialog.

Gonna change it to only display the notification once, but for any user missing it, there will be trouble helping to track down issues with hddtemp.
Comment 9 Fabian Nowak editbugs 2014-05-01 12:32:59 CEST
commit bcad538..4ada645 : suppress option is now also respected for notifications as well as for dialogs.

Bug #4142

Reported by:
Yves-Alexis Perez
Reported on: 2008-06-10
Last modified on: 2014-05-01

People

Assignee:
Xfce-Goodies Maintainers
CC List:
3 users

Version

Version:
unspecified

Attachments

Additional information