! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Incorrect desktop icon font size
Status:
RESOLVED: FIXED
Priority:
Very Low
Severity:
trivial
Product:
Xfdesktop
Component:
General

Comments

Description Lionel Le Folgoc 2008-03-22 11:30:42 CET
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4) Gecko/2008031317 Firefox/3.0b4
Build Identifier: 

(An ubuntu user reported this bug at: https://bugs.launchpad.net/ubuntu/+source/xfdesktop4/+bug/202970)

Xfdesktop has a little cosmetic issue when switching from "system font size" to "custom font size" in the settings manager.

1) I expect, that when in Applications -> Settings -> Settings manager -> Desktop -> Behavior I uncheck the "Use system font size" option, xfdesktop will use the size given in the "Custom font size" spinbox.

2) Instead of that, when I uncheck it first, it will use a size of 0px for the desktop icons' font size, so the text is unreadable (I will attach a screenshot with the checked and the unchecked state).

3) How to reproduce the bug?
This problem only happens, if the "Custom font size" option never changed, because if a change happens, the xfce-mcs-manager will store the value of the font size, and when unchecking the "Use system font size" checkbox, xfdesktop will load the stored setting. But if is no stored setting, xfdesktop will use the 0px.

4) Possible solution (#1)
Make xfce-mcs-manager store the value of the spinbox, when the spinbox change its state from insensitive to sensitive. (I think think this is the better solution.)
The first source file (behavior-settings.c), that I will attach, contains this solution.

5) Possible solution (#2)
Modify xfdesktop, to use a more sensible default value, such as 12px.
The second source file (xfce-desktop-settings.c), that I will attach contains this solution.

Reproducible: Always
Comment 1 Lionel Le Folgoc 2008-03-22 11:32:17 CET
Created attachment 1565 
Proposed patch (#1)
Comment 2 Lionel Le Folgoc 2008-03-22 11:33:20 CET
Created attachment 1566 
Proposed patch (#2)

Here are the two patches proposed by the bug reporter.
Comment 3 Lionel Le Folgoc 2008-03-22 11:34:31 CET
Created attachment 1567 
screenshot of the cosmetic issue
Comment 4 Lionel Le Folgoc 2008-03-22 11:35:22 CET
Created attachment 1568 
screenshot of the cosmetic issue
Comment 5 Pedro Soria-Rodriguez 2008-08-19 08:09:33 CEST
I can confirm this bug report, I observe the same problem.  

There's another issue with Desktop font size.  I think it is unrelated to this bug, and I have reported it in Bug 4295.
Comment 6 Brian J. Tarricone (not reading bugmail) 2008-08-27 11:37:01 CEST
Your first patch looks a little overly complicated -- I would think all that would be necessary would be to set the default value unconditionally.

Anyhow, new xfconf-based settings dialog for 4.6, and that doesn't seem to suffer from the same problem.  Pretty low-prio for me to fix in 4.4 right now.
Comment 7 Brian J. Tarricone (not reading bugmail) 2008-10-09 00:49:16 CEST
Sorry I didn't get back to this...  much much simpler 3-line fix checked in.  See here:
http://svn.xfce.org/index.cgi/xfce/revision/?rev=28108

Bug #3957

Reported by:
Lionel Le Folgoc
Reported on: 2008-03-22
Last modified on: 2009-07-14

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
1 user

Version

Attachments

Proposed patch (#1) (1.45 KB, patch)
2008-03-22 11:32 CET , Lionel Le Folgoc
no flags
Proposed patch (#2) (1.23 KB, patch)
2008-03-22 11:33 CET , Lionel Le Folgoc
no flags
screenshot of the cosmetic issue (54 bytes, text/plain)
2008-03-22 11:34 CET , Lionel Le Folgoc
no flags
screenshot of the cosmetic issue (122.16 KB, image/png)
2008-03-22 11:35 CET , Lionel Le Folgoc
no flags

Additional information