! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
hddtemp support for sensors plugin tries useless devices
Status:
RESOLVED: FIXED
Product:
Xfce4-sensors-plugin
Component:
General

Comments

Description Yves-Alexis Perez editbugs 2008-02-26 16:34:59 CET
A debian user reported that hddtemp support in sensors plugin broke the plugin completely.

It tries to look for a sensor in /dev/fd* wich is a nonsense, there's no temperature sensor in a floppy disk. This is because fd is not blacklisted when looking in /sys/block.

Attached patch should fixes the problem, but maybe there's a better way to do this?

Cheers,

--
Yves-Alexis
Comment 1 Yves-Alexis Perez editbugs 2008-02-26 16:47:19 CET
Created attachment 1525 
patch to not look at floppy drive when looking for temp sensors
Comment 2 Fabian Nowak editbugs 2008-02-28 22:23:37 CET
(In reply to comment #1)
Fixed in svn already a while ago.
Comment 3 Lionel Le Folgoc 2008-06-21 09:10:58 CEST
It seems to be the same issue with SD/MMC cards (e.g. /dev/mmcblk0), as they don't have temperature sensors afaik. Maybe /dev/mmc* or /dev/mmcblk* should be blacklisted as well.

(this was reported by an ubuntu user on https://bugs.launchpad.net/ubuntu/+source/xfce4-sensors-plugin/+bug/241846)
Comment 4 Yves-Alexis Perez editbugs 2008-06-21 09:15:56 CEST
Or maybe it would make sense to whitelist devices supposed to be supported by hddtemp?
Comment 5 Fabian Nowak editbugs 2008-06-21 11:02:35 CEST
(In reply to comment #4)

Well, yes and no. So we  must rely on all devices with temperature sensors being prefixed "sd" or "hd" and extend that information. Anyway. Done so in current version.

Comment 6 Fabian Nowak editbugs 2008-06-27 18:45:20 CEST
Anyone want to close it now with the whitelist od /dev/hd* and /dev/sd* as solution?
Comment 7 Yves-Alexis Perez editbugs 2008-06-28 03:59:54 CEST
Thanks, tested and seems to work!

Bug #3882

Reported by:
Yves-Alexis Perez
Reported on: 2008-02-26
Last modified on: 2009-07-15

People

Assignee:
Xfce-Goodies Maintainers
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information