! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[trunk] segfaults when opening a png file
Status:
RESOLVED: INVALID
Severity:
critical
Product:
Ristretto
Component:
Application

Comments

Description Lionel Le Folgoc 2007-08-19 10:49:20 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.6) Gecko/20070810 Ubuntu/7.10 (gutsy) Firefox/2.0.0.6
Build Identifier: 

Ristretto crashes when trying to open a png file.

Reproducible: Always

Steps to Reproduce:
1. Launch Ristretto
2. Open an image

Actual Results:  
It crashes

Expected Results:  
It should have displayed the picture

gtk 2.11.6
glib 2.13.7
Comment 1 Lionel Le Folgoc 2007-08-19 10:50:12 CEST
Created attachment 1316 
the image
Comment 2 Lionel Le Folgoc 2007-08-19 10:50:55 CEST
Created attachment 1317 
trace
Comment 3 Stephan Arts editbugs 2007-08-19 14:00:01 CEST
I have moved some stuff around while fixing a design-issue, so that backtrace is no longer valid. Could you verify this bug against svn-rev >= 3007?
Comment 4 Lionel Le Folgoc 2007-08-19 14:18:14 CEST
Created attachment 1319 
trace
Comment 5 Stephan Arts editbugs 2007-08-19 22:17:21 CEST
Created attachment 1320 
Does this fix it?

This patch should fix the previous segfault.
Comment 6 Stephan Arts editbugs 2007-08-19 23:41:24 CEST
(In reply to comment #5)
> Created an attachment (id=1320) [details]
> Does this fix it?
> 
> This patch should fix the previous segfault.
> 

The patch is applied against rev 3013.
Comment 7 Lionel Le Folgoc 2007-08-20 16:41:01 CEST
I updated to latest trunk revision (3019), and it doesn't crash anymore.

I have another bug though: I can't open any image file, they are grayed in the gtk filechooser dialog. I can open a directory, but it doesn't display the pictures, only their thumbnails (see attached screenshot).

It seems to be a different issue, so do you want me to file another bug?
Comment 8 Lionel Le Folgoc 2007-08-20 16:41:39 CEST
Created attachment 1321 
screenshot
Comment 9 Lionel Le Folgoc 2007-08-20 16:43:19 CEST
(In reply to comment #7)
> I updated to latest trunk revision (3019), and it doesn't crash anymore.
> 
> I have another bug though: I can't open any image file, they are grayed in the
> gtk filechooser dialog. I can open a directory, but it doesn't display the
> pictures, only their thumbnails (see attached screenshot).
> 
> It seems to be a different issue, so do you want me to file another bug?
> 

I forgot to say: I got nothing in gdb since it doesn't crash, only lots of gtk warnings (repeated several times):

(ristretto:13807): GLib-GObject-CRITICAL **: g_value_get_pointer: assertion `G_VALUE_HOLDS_POINTER (value)' failed

(ristretto:13807): GLib-GObject-CRITICAL **: g_value_get_pointer: assertion `G_VALUE_HOLDS_POINTER (value)' failed

(ristretto:13807): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_height: assertion `pixbuf != NULL' failed

(ristretto:13807): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_width: assertion `pixbuf != NULL' failed

Comment 10 Stephan Arts editbugs 2007-08-20 21:16:20 CEST
(In reply to comment #9)
> (In reply to comment #7)
> > I updated to latest trunk revision (3019), and it doesn't crash anymore.
> > 
> > I have another bug though: I can't open any image file, they are grayed in the
> > gtk filechooser dialog. I can open a directory, but it doesn't display the
> > pictures, only their thumbnails (see attached screenshot).
> > 
> > It seems to be a different issue, so do you want me to file another bug?
> > 
> 
> I forgot to say: I got nothing in gdb since it doesn't crash, only lots of gtk
> warnings (repeated several times):
> 
> (ristretto:13807): GLib-GObject-CRITICAL **: g_value_get_pointer: assertion
> `G_VALUE_HOLDS_POINTER (value)' failed
> 
> (ristretto:13807): GLib-GObject-CRITICAL **: g_value_get_pointer: assertion
> `G_VALUE_HOLDS_POINTER (value)' failed
> 
> (ristretto:13807): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_height: assertion
> `pixbuf != NULL' failed
> 
> (ristretto:13807): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_width: assertion
> `pixbuf != NULL' failed
> 

The directory thing is correct, I am debugging the thumbnail-viewer and opening a dir from the toolbar speeds up this process ;).

However, the gtk-warnings can not be reproduced using gtk 2.10, nor the fact it does not render the image. I have added an additional check to rev 3020, could you see if this improved a bit?
Comment 11 Lionel Le Folgoc 2007-08-21 17:15:47 CEST
Hi,

I have still the same warnings and this black-screen issue (gtk 2.11.6, glib 2.14.0). gdb doesn't display anything useful, do you need other infos? (strace, ltrace...)
Comment 12 Stephan Arts editbugs 2007-08-21 21:52:56 CEST
(In reply to comment #11)
> Hi,
> 
> I have still the same warnings and this black-screen issue (gtk 2.11.6, glib
> 2.14.0). gdb doesn't display anything useful, do you need other infos? (strace,
> ltrace...)
> 

an ltrace could be usefull, that way i could find out where those warnings come from.
Comment 13 Stephan Arts editbugs 2007-08-21 22:18:28 CEST
(In reply to comment #12)
> (In reply to comment #11)
> > Hi,
> > 
> > I have still the same warnings and this black-screen issue (gtk 2.11.6, glib
> > 2.14.0). gdb doesn't display anything useful, do you need other infos? (strace,
> > ltrace...)
> > 
> 
> an ltrace could be usefull, that way i could find out where those warnings come
> from.
> 

nm... i found it.
Comment 14 Stephan Arts editbugs 2007-08-22 07:17:07 CEST
(In reply to comment #13)
> (In reply to comment #12)
> > (In reply to comment #11)
> > > Hi,
> > > 
> > > I have still the same warnings and this black-screen issue (gtk 2.11.6, glib
> > > 2.14.0). gdb doesn't display anything useful, do you need other infos? (strace,
> > > ltrace...)
> > > 
> > 
> > an ltrace could be usefull, that way i could find out where those warnings come
> > from.
> > 
> 
> nm... i found it.
> 

Forget i said that, i fixed a bug but this could be something else. Could you please give me an ltrace if it still doesn't work?
Comment 15 Lionel Le Folgoc 2007-08-22 21:25:29 CEST
Created attachment 1328 
ltrace

Yes, I still have the same issue. I attached the ltrace output, maybe it'll be useful to you.
Comment 16 Stephan Arts editbugs 2007-08-28 05:43:37 CEST
Do you have the shared-mime-info package installed? (Might be related to not displaying the image)
Comment 17 Lionel Le Folgoc 2007-08-28 17:34:03 CEST
Yeah, the shared-mime-info package is already installed.
Comment 18 Stephan Arts editbugs 2007-08-30 15:06:26 CEST
I just installed gtk 2.11, and i get the same output.

A little more debugging information (r 3105) suggests the scrolledwindow of gtk 2.11.6 is broken. The picture-viewer does not receive any adjustments.
Comment 19 Lionel Le Folgoc 2007-09-17 13:44:52 CEST
It now works with gtk+ 2.12.
This was indeed a gtk 2.11.6 bug.
Thanks.

Bug #3479

Reported by:
Lionel Le Folgoc
Reported on: 2007-08-19
Last modified on: 2009-07-14

People

Assignee:
Stephan Arts
CC List:
0 users

Version

Version:
unspecified

Attachments

the image (50.95 KB, image/png)
2007-08-19 10:50 CEST , Lionel Le Folgoc
no flags
trace (29.75 KB, text/plain)
2007-08-19 10:50 CEST , Lionel Le Folgoc
no flags
trace (65.99 KB, text/plain)
2007-08-19 14:18 CEST , Lionel Le Folgoc
no flags
Does this fix it? (3.98 KB, patch)
2007-08-19 22:17 CEST , Stephan Arts
no flags
screenshot (116.77 KB, image/png)
2007-08-20 16:41 CEST , Lionel Le Folgoc
no flags
ltrace (665.44 KB, text/x-log)
2007-08-22 21:25 CEST , Lionel Le Folgoc
no flags

Additional information