3280 – gtk-xfce-engine-2 'make install' is broken, installs redudant files.

gtk-xfce-engine-2 'make install' is broken, installs redudant files.

Status:

CLOSED: FIXED

Priority:
Medium

Severity:
normal

Product:
Gtk-xfce-engine

Component:

General

Comments

Description Samuli Suominen 2007-05-25 14:58:11 CEST

'make install' seems broken as it installs these,

/usr/share/themes/Xfce-smooth/README.html
/usr/share/themes/Xfce-smooth/ICON.png
/usr/share/themes/Xfce/README.html
/usr/share/themes/Xfce/ICON.png
/usr/share/themes/Xfce-winter/README.html
/usr/share/themes/Xfce-winter/ICON.png
/usr/share/themes/Xfce-stellar/README.html
/usr/share/themes/Xfce-stellar/ICON.png
/usr/share/themes/Xfce-saltlake/README.html
/usr/share/themes/Xfce-saltlake/ICON.png
/usr/share/themes/Xfce-b5/README.html
/usr/share/themes/Xfce-b5/ICON.png
/usr/share/themes/Xfce-4.0/README.html
/usr/share/themes/Xfce-4.0/ICON.png
/usr/share/themes/Xfce-4.2/README.html
/usr/share/themes/Xfce-4.2/ICON.png
/usr/share/themes/Xfce-redmondxp/README.html
/usr/share/themes/Xfce-redmondxp/ICON.png
/usr/share/themes/Xfce-cadmium/README.html
/usr/share/themes/Xfce-cadmium/ICON.png
/usr/share/themes/Xfce-dawn/README.html
/usr/share/themes/Xfce-dawn/ICON.png
/usr/share/themes/Xfce-dusk/README.html
/usr/share/themes/Xfce-dusk/ICON.png
/usr/share/themes/Xfce-kde2/README.html
/usr/share/themes/Xfce-kde2/ICON.png
/usr/share/themes/Xfce-kolors/README.html
/usr/share/themes/Xfce-kolors/ICON.png
/usr/share/themes/Xfce-orange/README.html
/usr/share/themes/Xfce-orange/ICON.png
/usr/share/themes/Xfce-basic/README.html
/usr/share/themes/Xfce-basic/ICON.png
/usr/share/themes/Xfce-curve/README.html
/usr/share/themes/Xfce-curve/ICON.png
/usr/share/themes/Xfce-light/README.html
/usr/share/themes/Xfce-light/ICON.png

where ICON.png is file, sized 0 bytes and README.html is allways same with content,

-- cut --

<pre>
The default GTK theme with Xfce engine.

Olivier Fourdan &lt;fourdan@xfce.org&gt;
</pre>

-- cut --

Comment 1 Samuli Suominen 2007-05-25 15:18:31 CEST

For record,

sed -i -e 's:ICON.png README.html::g' themes/*/Makefile*

Comment 2 Samuli Suominen 2008-12-08 22:50:02 CET

The problem is still there with latest version 2.4.3, with every Makefile.am files in themes/ these are redudant:

theme_DATA = ICON.png README.html
EXTRA_DIST = $(theme_DATA)

Can we get this simple thing fixed? Delete all the ICON.png, README.html files and remove these lines from Makefile.am's. They are duplicates... and ends up
at end users system.

Comment 3 Samuli Suominen 2009-07-09 22:27:25 CEST

Looks like this bug is fixed in 2.6.0

Thanks, appericiated :-)

Closing

Comments

Bug #3280

People

Version

Attachments

Additional information