! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-battery-plugin-0.5.0: No display of temperature or fan status
Status:
RESOLVED: FIXED
Product:
Xfce4-battery-plugin
Component:
General

Comments

Description Ulrich Mueller 2007-02-08 20:42:27 CET
On a HP Compaq nc6120 laptop, the battery plugin does neither display the temperature nor the fan status.

Attached patch should fix the problem.

Reproducible: Always
Steps to Reproduce:
1. Start battery panel plugin
Actual Results:  
Temperature and fan status are not shown.

Expected Results:  
Temperature and fan status being displayed.


Note: libacpi.c contains lines like the following:
    proc_fan_status="/proc/acpi/fan/*/state";
    if ( (fp=fopen(proc_fan_status, "r")) == NULL ) return 0;
This cannot work since fopen does not expand wildcards.
Comment 1 Ulrich Mueller 2007-02-08 20:45:17 CET
Created attachment 986 
Proposed bugfix (patch for panel-plugin/libacpi.c)
Comment 2 Yves-Alexis Perez editbugs 2008-09-07 15:36:08 CEST
Why would a *battery* plugin display the fan or temperature status?
Comment 3 Ulrich Mueller 2008-09-07 17:25:23 CEST
(In reply to comment #2)
> Why would a *battery* plugin display the fan or temperature status?

Of course, that is not mandatory.

But if the application contains the feature, then it should work and not be broken on some hardware platforms.
Comment 4 Ulrich Mueller 2008-09-10 16:08:38 CEST
> But if the application contains the feature, then it should work and not be
> broken on some hardware platforms.

In fact it is broken on any ACPI hardware. To quote from the corresponding Gentoo bug <http://bugs.gentoo.org/165989>:

"Please note that this bug should be present on _any_ (ACPI) hardware: The plugin tries to fopen a file "/proc/acpi/fan/*/state" which cannot work, since fopen of course doesn't expand wildcards. This is a regression from the 0.3.0 version."
Comment 5 Florian Rivoal editbugs 2010-12-27 17:13:11 CET
Patch applied. Thanks

Bug #2884

Reported by:
Ulrich Mueller
Reported on: 2007-02-08
Last modified on: 2010-12-27

People

Assignee:
Xfce-Goodies Maintainers
CC List:
4 users

Version

Version:
0.5.1 or older

Attachments

Additional information