! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Plugin small libxfcegui4 leaks and reduce relocations
Status:
RESOLVED: FIXED
Product:
Libxfcegui4
Component:
General

Comments

Description Nick Schermer editbugs 2006-10-04 18:56:24 CEST
I hope this one makes sense Benny :-).

* Reduce relocations using _netk_g_type_register_simple
* Free class_groups lists
Comment 1 Nick Schermer editbugs 2006-10-04 18:56:44 CEST
Created attachment 815 
Patch
Comment 2 Benedikt Meurer editbugs 2006-10-28 13:31:48 CEST
A test for newer glib (2.10) would be nice and if found, pass the result of g_intern_static_string() for type_name in _netk_g_type_register_simple(), otherwise pass type_name as is, so that static strings don't need to be duplicated on the heap.
Comment 3 Nick Schermer editbugs 2006-10-28 18:28:37 CEST
Created attachment 845 
Patch v2

Same patch but with the I_(...) macro, also for g_signal_new.
Comment 4 Benedikt Meurer editbugs 2006-11-03 18:57:11 CET
One last thing: Signals should use the canonical form, that is '-' instead of '_'. Otherwise I_() for signals doesn't save any memory. ;-)
Comment 5 Benedikt Meurer editbugs 2006-11-03 18:59:44 CET
Err, ups, the other way round, '_' is the canonical form. ;-)
Comment 6 Benedikt Meurer editbugs 2006-11-03 19:06:48 CET
Meh, confusing myself... The canonical form is using '-', that's the way used to store the signal node, but the '_'-form is also registered as quark. So, it doesn't even matter which way you use it.
Comment 7 Benedikt Meurer editbugs 2006-11-03 19:15:53 CET
Committed with revision 23615.

Bug #2377

Reported by:
Nick Schermer
Reported on: 2006-10-04
Last modified on: 2009-07-14

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Version:
unspecified

Attachments

Patch (17.03 KB, patch)
2006-10-04 18:56 CEST , Nick Schermer
no flags
Patch v2 (28.67 KB, patch)
2006-10-28 18:28 CEST , Nick Schermer
no flags

Additional information