! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Discrepancy between the icon showed in thunar and on the desktop
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Riccardo Magliocchetti 2006-06-26 10:05:02 CEST
I get an horrible icon in the desktop while it is perfectly nice in thunar. Screenshot attached.

I'm using debian unstable's xfce4 4.3.90 and thunar 0.3.0beta1 with gnome icon theme.

Thanks in advance.

ps. i'm filing this under thunar because AFAIK xfdesktop uses thunar libs for desktop icons
Comment 1 Riccardo Magliocchetti 2006-06-26 10:06:08 CEST
Created attachment 617 
Two different icons, one nice and one horrible
Comment 2 Benedikt Meurer editbugs 2006-06-29 09:18:00 CEST
Brian, any ideas?
Comment 3 Brian J. Tarricone (not reading bugmail) 2006-06-29 16:41:48 CEST
Nope.
Comment 4 Benedikt Meurer editbugs 2006-07-01 10:11:35 CEST
Ah, I know. thunar_file_get_icon_name() tries to use the binary name to lookup an icon for executables, while xfdesktop doesn't do that.
Comment 5 Brian J. Tarricone (not reading bugmail) 2006-07-11 19:56:53 CEST
That sounds like the kind of hack you don't like, Benny ^_~.  So how are you doing it - check the binary name first, or last?
Comment 6 Benedikt Meurer editbugs 2006-07-12 14:24:01 CEST
Well, it's a hack, definitely, but it improves the usability; so it's worth it.

Basicly:

1) Check if it's the root node -> "gnome-dev-harddisk"
2) Check if it's the home node -> "gnome-fs-home"
3) Check if executable and the file name is a valid icon name -> file name
4) thunar_vfs_mime_info_lookup_icon_name()
Comment 7 Brian J. Tarricone (not reading bugmail) 2006-07-12 19:17:57 CEST
Ok, I dispensed with the first two since desktop items won't be the root item or the home folder (though I guess you could have links, but... whatever).  Should be fixed.

Bug #1956

Reported by:
Riccardo Magliocchetti
Reported on: 2006-06-26
Last modified on: 2009-07-14

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
1 user

Version

Attachments

Two different icons, one nice and one horrible (18.55 KB, image/jpeg)
2006-06-26 10:06 CEST , Riccardo Magliocchetti
no flags

Additional information