Created attachment 9538 coredump output I use ArchLinux with xfce4-terminal 0.8.9.1-1 and Xfce DE 4.14.1 . For many months, somtimes I can not paste into xfce4-terminal anymore from an external applications (e,g. Firefox). i open xfce-terminal, open a file in vim app, and place cursor on a desired line, in browsing (non-edit) mode. I switch focus to an external app, select text with a mouse left key and right key and Copy, then switch focus via panel back to terminal and paste it with right key and Paste. At this moment the terminal disappears and and I see a dump generated (see attachment). TIME PID UID GID SIG COREFILE EXE Thu 2020-03-05 12:20:45 CET 5978 1000 1000 6 present /usr/bin/xfce4-terminal
Hi jb, thanks for the report! The coredump doesn't seem to indicate any particular problem, unfortunately. Is the issue reproducible for you? Can you provide a block of text pasting which causes the issue?
One more question - do you have "Unsafe paste dialog" enabled? (Preferences -> General -> Show unsafe paste dialog)
The "Show unsafe paste dialog" is not enabled; btw, there are no custom configurations. But I remember some months ago such a dialog popping up (without causing a crash), warning me about pasting of unsafe text, but I ignored it and it stopped some time later (perhaps the option was enabled at that time per default, but I did not pay attention to config). I tried to reproduce it, but no success. But it happens every 2-3 weeks. I will try to save the offending block of text next time.
Created attachment 9606 core dump
This time a little bit different circumstance, with "Show unsafe paste dialog" ON. I was in xfce terminal, in text file opened in vim. I selected "clipboard manager" text with left mouse key and next I pressed right mouse key to show copy/paste dialog, repeatedly. At this point the terminal died. Note: [jb@r61i ~]$ coredumpctl gdb <output> With "Show unsafe paste dialog" ON, I selected the output to copy/paste, then warning window showed up about insecure copy/paste, I ignoed it and pasted, but the dump file recorded a distorted/reformatted text (see: attachment). I turned "Show unsafe paste dialog" OFF and repeated copy/paste, this time with output as original. Perhaps this "Show unsafe paste dialog" is an overkill/a misfeature ?
Pasting text that has newlines is done differently if the unsafe-paste-dialog is shown. It uses vte_terminal_feed_child in terminal/terminal-screen.c instead of vte_terminal_paste_primary/vte_terminal_paste_clipboard (which would happen when unsafe-paste-dialog were disabled in settings) I think this is why, for example, bash (in its 'devel' branch) cannot detect the text as pasted and thus cannot highlight it(yes, a new feature in bash, in 'devel' branch) as it would for non-newlines text or for new-lines text pasted when the unsafe-paste-dialog isn't shown(because it's disabled in settings).
Hi jb, Would it be possible for you to try out the git master version? Since commit https://git.xfce.org/apps/xfce4-terminal/commit?id=50fccff2872179e686ecb544253381dc520e9ec0, vte_terminal_paste_primary()/vte_terminal_paste_clipboard() are used by the "unsafe paste" dialog which might help with your issue.
I am geting a build error: $ makepkg ... make[3]: Entering directory '/home/jb/Downloads/xfce4-terminal-50fccff2872179e686ecb544253381dc520e9ec0/src/xfce4-terminal-0.8.9.2/terminal' make[3]: *** No rule to make target 'terminal-enum-types.c', needed by 'xfce4_terminal-terminal-enum-types.o'. Stop. make[3]: Leaving directory '/home/jb/Downloads/xfce4-terminal-50fccff2872179e686ecb544253381dc520e9ec0/src/xfce4-terminal-0.8.9.2/terminal' make[2]: *** [Makefile:525: all] Error 2 ... => ERROR: A failure occurred in build(). Aborting... There is no file terminal-enum-types.c . But there are references to it in Makefile when I 'grep -ir terminal-enum-types ...' in project dir. Can you verify that (I tested on 2 last commits) ?
Please run `./autogen.sh && ./configure`.
There is an inconsistency in compilation-from-source bahavior for this application. Tested on latest commit in master: xfce4-terminal-edcd23c62f721ecf23e852ded9191892b9d0c87f.tar.gz BAD run; $ tar xvf xfce4-terminal-edcd23c62f721ecf23e852ded9191892b9d0c87f.tar.gz $ cd xfce4-terminal-edcd23c62f721ecf23e852ded9191892b9d0c87f ./autogen.sh ./configure make Output (attachments): autogen.out-bad configure.out-bad make.out-bad Note: missing terminal/terminal-enum-types.c GOOD run: $ tar xvf xfce4-terminal-edcd23c62f721ecf23e852ded9191892b9d0c87f.tar.gz $ cd xfce4-terminal-edcd23c62f721ecf23e852ded9191892b9d0c87f ./autogen.sh Note: no ./configure run make Output (attachments): autogen.out-good make.out-good Note: generated terminal/terminal-enum-types.c GEN terminal-enum-types.c CC xfce4_terminal-terminal-enum-types.o So, I have a test app now and will see what happens (as I said, the problem occured randomly every few weeks - we have to patient for any sign of error, if any).
Created attachment 9789 autogen bad run
Created attachment 9790 configure bad run
Created attachment 9791 make bad run
Created attachment 9792 autogen good run
Created attachment 9793 make good run
Indeed, running `./configure` seems to break things. I'll try to look into this, thanks!
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/xfce4-terminal/-/issues/49. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev