! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Missing results when following links
Status:
RESOLVED: FIXED
Product:
Catfish
Component:
General

Comments

Description Filip Brygidyn 2019-12-30 18:38:08 CET
Created attachment 9342 
proposed_patch

With following dir structure:
         -wine+
              +-drive_c+
                    +test+
                         +test.txt
                    +test2.txt
              +-dosdevices+
                     +c:->../drive_c

With  only 'walk' method enabled I launch catfish in 'dosdevices' directory and search for 'test'.
On 1.4.10 I find 'test.txt' and 'test2.txt'.
On 1.4.11 I find 'test.txt' only.
Correct would be to find 'test.txt', 'test2.txt' and 'test'

My previous patch that fixed the link looping (cac84de5) introduced this bug, I attached a patch to fix it
After applying it the search results seem to be correct.
Comment 1 Git Bot editbugs 2020-01-15 02:04:59 CET
Filip Brygidyn referenced this bugreport in commit fdb9376dc63a3433814810adbf581af0d78813f6

Walk Method: Consider symlinks as visited only after actually following them (bug #16318)

https://git.xfce.org/apps/catfish/commit?id=fdb9376dc63a3433814810adbf581af0d78813f6
Comment 2 Sean Davis editbugs 2020-01-15 02:05:29 CET
Thanks for the patch. Applied above.

Bug #16318

Reported by:
Filip Brygidyn
Reported on: 2019-12-30
Last modified on: 2020-01-15

People

Assignee:
Sean Davis
CC List:
0 users

Version

Version:
1.4.11

Attachments

proposed_patch (1.03 KB, patch)
2019-12-30 18:38 CET , Filip Brygidyn
no flags

Additional information