! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Random theme does not change theme over time.
Status:
RESOLVED: MOVED
Product:
Xfce4-screensaver
Component:
General

Comments

Description icanttellyou 2019-10-25 19:51:14 CEST
When I selected to use the random theme in xfce4-screensaver, it uses the random screensaver. But it does not change after the specified amount of time.
Comment 1 icyrock.com 2020-04-11 20:48:10 CEST
Debug log shows the cycling happening:

gs_job_start] gs-job.c:453 (14:01:50.943):	 Starting job
[gs_manager_cycle] gs-manager.c:353 (14:02:50.909):	 Cycling jobs
[gs_job_stop] gs-job.c:499 (14:02:50.909):	 Stopping job
[gs_job_died] gs-job.c:124 (14:02:50.909):	 Waiting on process 7103
[gs_job_died] gs-job.c:138 (14:02:50.928):	 Job finished
[manager_maybe_start_job_for_window] gs-manager.c:175 (14:02:50.928):	 Starting job for window
[gs_job_start] gs-job.c:453 (14:02:50.928):	 Starting job
[gs_job_stop] gs-job.c:499 (14:02:50.930):	 Stopping job
[gs_job_died] gs-job.c:124 (14:02:50.930):	 Waiting on process 7104
[gs_job_died] gs-job.c:138 (14:02:50.937):	 Job finished
[manager_maybe_start_job_for_window] gs-manager.c:175 (14:02:50.937):	 Starting job for window
[gs_job_start] gs-job.c:453 (14:02:50.937):	 Starting job
[gs_job_stop] gs-job.c:499 (14:02:50.938):	 Stopping job
[gs_job_died] gs-job.c:124 (14:02:50.938):	 Waiting on process 7105
[gs_job_died] gs-job.c:138 (14:02:50.945):	 Job finished
[manager_maybe_start_job_for_window] gs-manager.c:175 (14:02:50.945):	 Starting job for window
[gs_job_start] gs-job.c:453 (14:02:50.945):	 Starting job
[gs_manager_cycle] gs-manager.c:353 (14:03:50.910):	 Cycling jobs
[gs_job_stop] gs-job.c:499 (14:03:50.910):	 Stopping job

However, inspecting the actual processes, the same process (e.g. /usr/lib/xscreensaver/galaxy -root) is started every time.

Looking at the code (gs-manager.c:163), I see this:

    job = g_hash_table_lookup (manager->priv->jobs, window);

so looks like the job is fixed per window.

The jobs are refreshed on activate, since hash table is re-created (gs-manager.c:1263). Themes are set only on job creation in gs_job_set_theme (gs-job.c:244).
Comment 2 Git Bot editbugs 2020-05-25 22:27:01 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/xfce4-screensaver/-/issues/21.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16092

Reported by:
icanttellyou
Reported on: 2019-10-25
Last modified on: 2020-05-25

People

Assignee:
Sean Davis
CC List:
1 user

Version

Attachments

Additional information