! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Provide a collection of preinstalled custom actions, which can be enabled
Status:
RESOLVED: MOVED
Priority:
Very Low
Severity:
enhancement

Comments

Description alexxcons editbugs 2019-05-23 23:07:45 CEST
Currently a long list of all sort of possible custom actions exists in the Wiki:
https://docs.xfce.org/xfce/thunar/custom-actions

However we only provide a single one by default, which is "open terminal here".  And I bet many users dont even know about the existence of the wiki page.

So the idea would be:
1. Add all UCA's we have on the Wiki page to thunar per default (Side effect: Translations for all predefined ucas possible) 
2. Add some bool attribute "enabled" to each uca. So that we can only enable "open terminal here" by default. Disabled ucas should be grayed out in the uca-list, and ofc not shown in the context menu.
3. We can check if required packages for a specific uca are installed and give an error if not installed on toggle "enabled".

You would like such a feature ?

I explicitly dont want to follow the dolphin approach (load "services" from a server, just like an appstore), since I think it is a potential security risk to bypass the package manager and execute 3rd party code just like that.

.. not that I have time to start implementation on it. :P Just as a reminder for myself, for some later day.
Comment 1 Andre Miranda editbugs 2019-05-24 03:23:00 CEST
(In reply to alexxcons from comment #0)
> You would like such a feature ?
Are you asking this to me? :)

Well, I mostly disagree, we can for sure ship some more actions, the idea to make them disable by the default is a very good one, but there many from the wiki that doesn't make sense to the average user IMHO.

"Finding files inside the current/selected folder with catfish/gnome-search-tool" - catfish at least is now an official project.
"Working with archives (tar, gzip, etc)" - What about TAP?
"Playing music files" - xmms? what about mpc, clementine, vlc, Gnome music and Spotify? I think that's the reason we have "Open with".
"Burning an ISO file to a CD" - Same
"Viewing images" - Same
"Converting PNGs to JPEGs" - What about gif, webp, tiff...?
"Losslessly Rotating JPEGs" - Image viewers can do that, or just open the file with Gimp
"* as root" - Not sure it's a good idea to ship this, anyone that cares to do stuff as root will do it in a terminal or is savvy enough to create the custom action.
"Creating a symbolic link" - What about drag + ctrl + shift?
"Saving the selected file/folder's pathname to the clipboard" -  When copying a file/folder and pasting in a text field we get the full path
"Setting an image as the desktop background" - We already have a plugin for this.
"Viewing the disk usage of the current directory" - Folder properties already shows this info
"Using 'nano' text editor in a terminal" - What about vim, visual studio code, atom, intellij...?
"Download subtitles with periscope" -  Why not download stock prices, format them as csv and open Calc?

My point is: most of them are specific to few users, even with them disabled by default they would clutter the actions list. I think makes more sense to put in the dialog something catchy like "Custom actions are very powerful if you are creative. Have a look at what is possible." that would be link to this wiki.
Comment 2 alexxcons editbugs 2019-05-24 11:16:16 CEST
Thanks for the feedback !

Hehe, looks like I was a bit too focused on some specific ucas I had in mind, and actually forgot to check what all the ucas in the Wiki are about :P
I agree with you for most of the ucas in the wiki !

So lets identify a subset of ucas for which it makes sense.
I would propose the following:
-  "catfish search"
- "Converting PNGs to JPEGs"
>  What about gif, webp, tiff...?
Looks like the name of the uca is bad. "Convert" seems to be able to convert alot of formats. I would keep it as "convert to jpg".
- "Rotating JPEGs" 
> Image viewers can do that, or just open the file with Gimp
That's actually a uca I use alot. Via ristretto or gimp many clicks are required. Real nice if you dont need to leave thunar for rotating pictures.
- "Creating a symbolic link"
> What about drag + ctrl + shift?
IMO would be nice to have a default UCA for it since many people (including me :P) might not know the shortcut / might like to have to option in the context menu.
- Comparing selected files/directories 
Ok, there are more diff viewers than "meld" out there. However would be nice to start with something to show the possibility ... maybe we can exec. diff in a terminal ? User can replace  by some more advanced diff viewer on its own, if required.
- Move files into a new folder
Comment 3 alexxcons editbugs 2019-05-24 11:24:40 CEST
> I think makes more sense to put in the dialog something catchy like "Custom actions are very powerful if you are creative. Have a look at what is possible." that would be link to this wiki.
Agreed, a link t the wiki is a nice idea !
Comment 4 ctac 2019-05-27 19:19:46 CEST
I think only one custom action is needed by default to explain how this work.
Open terminal here is a good one but ...
- There is no help button to go to the wiki in the dialog box.
- on my debian system, this shortcut is named 'Ouvrir un terminal ici' in french.
I think the défault shortcut must look like all default desktop file in uca.xml file with :
	<name>Open Terminal here</name>
	<name xml:lang="fr">Ouvrir un terminal ici</name>
.
.
.
    <description>Example for a custom action</description>
    <description xml:lang="fr">Exemple d’une action personnalisée</description>
.
.
.
The default file in /etc/xdg/Thunar/uca.xml have all the lang but in ~/.config/Thunar/uca.xml, there is only french.
I think it's better to keep all the lang if we want to change for some reason and to explain how this work.
Comment 5 Andre Miranda editbugs 2019-05-28 03:05:51 CEST
(In reply to alexxcons from comment #2)
> I would propose the following:
> -  "catfish search"
> - "Converting PNGs to JPEGs"
> >  What about gif, webp, tiff...?
> Looks like the name of the uca is bad. "Convert" seems to be able to convert
> alot of formats. I would keep it as "convert to jpg".
Ok.

> - "Rotating JPEGs" 
> > Image viewers can do that, or just open the file with Gimp
> That's actually a uca I use alot. Via ristretto or gimp many clicks are
> required. Real nice if you dont need to leave thunar for rotating pictures.
I still think this one is very specific, but I won't mind shipping it as long as disabled by default.

> - "Creating a symbolic link"
> > What about drag + ctrl + shift?
> IMO would be nice to have a default UCA for it since many people (including
> me :P) might not know the shortcut / might like to have to option in the
> context menu.
Ok, as long as disabled by default.

> - Comparing selected files/directories 
> Ok, there are more diff viewers than "meld" out there. However would be nice
> to start with something to show the possibility ... maybe we can exec. diff
> in a terminal ? User can replace  by some more advanced diff viewer on its
> own, if required.
> - Move files into a new folder
And which would be the default diff app? Calling the terminal for this is kinda weird IMO. I think this one could live in the wiki, we may reevaluate someday.
Comment 6 Andre Miranda editbugs 2019-05-28 03:08:30 CEST
(In reply to ctac from comment #4)
> - There is no help button to go to the wiki in the dialog box.
That's what I proposed in comment1, likely to be included with the proposed custom actions.

> The default file in /etc/xdg/Thunar/uca.xml have all the lang but in
> ~/.config/Thunar/uca.xml, there is only french.
> I think it's better to keep all the lang if we want to change for some
> reason and to explain how this work.
And that's something we may handle in another bug.
Comment 7 alexxcons editbugs 2019-05-28 12:15:47 CEST
(In reply to Andre Miranda from comment #5)
> > - Comparing selected files/directories 
> > Ok, there are more diff viewers than "meld" out there. However would be nice
> > to start with something to show the possibility ... maybe we can exec. diff
> > in a terminal ? User can replace  by some more advanced diff viewer on its
> > own, if required.
> > - Move files into a new folder
> And which would be the default diff app? Calling the terminal for this is
> kinda weird IMO. I think this one could live in the wiki, we may reevaluate
> someday.
The idea was to use "diff" as the default app, running in a terminal, to be neutral .. though might not be me my best idea :)  As well ok for me to just keep "Compare selected files/directories " in the wiki.
Comment 8 Git Bot editbugs 2020-05-26 23:43:24 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/thunar/-/issues/245.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15454

Reported by:
alexxcons
Reported on: 2019-05-23
Last modified on: 2020-05-26

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Attachments

Additional information