! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Regression] In pathbar style, opening folders in new tabs with middle mouse ...
Status:
RESOLVED: FIXED

Comments

Description ondondil 2019-04-18 13:44:09 CEST
Thunar version: 
1.8.4

Platform info:
Xubuntu 19.04 Disco Dingo

Description:
In Thunar, if you set the Location Selector view to Pathbar Style and enable option to "Open folders in new tabs on middle click", clicking on a folder in pathbar with middle mouse button does not open that folder in a new tab.
If you try to do the same thing with "Open folders in new tabs on middle click" option disabled, Thunar successfully opens the folder in a new window.

Steps to reproduce:
1. Open Thunar and change View / Location Selector to "Pathbar Style"
2. Open Edit / Preferences / Behavior and enable "Open folders in new tabs on middle click" option
3. Try to open a folder in a new tab by clicking on folder name in the pathbar with middle mouse button

Expected behavior:
Folder is opened in a new tab

Actual behavior:
Folder is opened in a current tab
Comment 1 ondondil 2019-04-18 15:53:40 CEST
Update:
Thunar 1.8.1 has the same problem (tested in Xubuntu 18.10 Cosmic Cuttlefish) if you set Edit / Preferences / Behavior / Middle click / Open folder in new tab.

Feature works as expected in Thunar 1.6.15 (Xubuntu 18.04 Bionic Beaver).
Comment 2 Theo Linkspfeifer editbugs 2019-04-18 20:16:05 CEST
https://git.xfce.org/xfce/thunar/tree/thunar/thunar-location-button.c#n562

The g_signal_emit() call was changed to g_signal_emit_by_name() [1], but the parameter list was not adjusted [2]. Simply removing the '0' fixes the bug.

---
[1] https://git.xfce.org/xfce/thunar/commit/thunar/thunar-location-button.c?id=a90fb8a4d9c9c21507917cbaa7b4b050c50092be
[2] https://developer.gnome.org/gobject/stable/gobject-Signals.html#g-signal-emit
Comment 3 Git Bot editbugs 2019-04-19 03:34:49 CEST
Andre Miranda referenced this bugreport in commit f3af9583d7cd3defd49e8600452e48960234a669

Fix pathbar to on middle click open folders in new tabs (Bug #15302)

https://git.xfce.org/xfce/thunar/commit?id=f3af9583d7cd3defd49e8600452e48960234a669
Comment 4 Andre Miranda editbugs 2019-04-19 03:35:47 CEST
(In reply to Theo Linkspfeifer from comment #2)
> The g_signal_emit() call was changed to g_signal_emit_by_name() [1], but the
> parameter list was not adjusted [2]. Simply removing the '0' fixes the bug.

Good catch, thanks a lot, next time send a patch so I will give you the credits ;)
Comment 5 Git Bot editbugs 2019-05-18 22:25:38 CEST
Andre Miranda referenced this bugreport in commit e0ae19598b53f3f3199881fc3481c1a61b9e5965

Fix pathbar to on middle click open folders in new tabs (Bug #15302)

https://git.xfce.org/xfce/thunar/commit?id=e0ae19598b53f3f3199881fc3481c1a61b9e5965

Bug #15302

Reported by:
ondondil
Reported on: 2019-04-18
Last modified on: 2019-05-18

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Attachments

Additional information