! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Use gdk_seat_grab/gdk_seat_ungrab instead deprecated functions
Status:
RESOLVED: FIXED
Product:
Xfce4-screenshooter
Component:
General

Comments

Description Olivier Duchateau 2018-05-05 21:16:39 CEST
Created attachment 7713 
Replace deprecated functions

Patch replaces deprecated functions gdk_device_grab/gdk_device_ungrab. They are deprecated since Gtk 3.20, and this is the mininal version of Gtk (configure script),  I think we should avoid using these functions.
Comment 1 Andre Miranda editbugs 2018-05-05 23:35:33 CEST
This week I replaced those functions exactly as you did, but it breaks rectangle selection when not using a compositor.
Go to Window Manager Tweaks -> Compositor, uncheck Enable display compositing and run xfce4-screenshooter -r, you get:

(xfce4-screenshooter:21305): Gdk-CRITICAL **: 18:34:50.965: Window 0x5578fa668010 has not been made visible in GdkSeatGrabPrepareFunc

Bug #14382

Reported by:
Olivier Duchateau
Reported on: 2018-05-05
Last modified on: 2019-03-26

People

Assignee:
Jérôme Guelfucci
CC List:
1 user

Version

Attachments

Replace deprecated functions (4.67 KB, patch)
2018-05-05 21:16 CEST , Olivier Duchateau
no flags

Additional information