! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Regression: launcher icons based on pixbufs don't resize anymore
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Launcher

Comments

Description Simon Steinbeiss editbugs 2018-01-03 16:38:46 CET
This was already reported as part of https://bugzilla.xfce.org/show_bug.cgi?id=13962.

If you add a launcher that has an icon file instead of a name in its desktop file, the pixbuf will be created correctly, but upon resizing the panel, the launcher's icon will not resize anymore.

This is due to the switch from xfce_panel_image to GtkImage, which provides resizing for icons basd on icon names, but not for pixbufs. So either we switch back to xfce_panel_image which had all the necessary resize magic for pixbufs (and maybe try to fix its sizing to be on par with the new xfce_panel_plugin_get_icon_size call) or we have to re-implement all that magic on top of gdkpixbuf by attaching to the size_changed callback.
Comment 1 Git Bot editbugs 2018-01-03 22:25:25 CET
Simon Steinbeiss referenced this bugreport in commit f8441b8bfa4c945293f4def5cfd9a3591f79d8d4

launcher: Fix resizing of pixbuf based icons (Bug #14138)

https://git.xfce.org/xfce/xfce4-panel/commit?id=f8441b8bfa4c945293f4def5cfd9a3591f79d8d4

Bug #14138

Reported by:
Simon Steinbeiss
Reported on: 2018-01-03
Last modified on: 2018-01-03

People

Assignee:
Simon Steinbeiss
CC List:
0 users

Version

Version:
4.13.0

Attachments

Additional information