! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Quick port to Thunarx-3
Status:
RESOLVED: FIXED
Product:
Thunar-archive-plugin
Component:
General

Comments

Description Ali Akcaagac 2017-10-31 16:41:10 CET
Created attachment 7403 
thunar-archive.patch

Please find attached a quick port to Thunarx-3. No further testing was done with this because I needed the plugins to be buildable again.
Comment 1 Ali Akcaagac 2017-10-31 16:48:18 CET
Created attachment 7405 
thunar-archive.patch including configure adjustments
Comment 2 Ali Akcaagac 2017-10-31 18:29:29 CET
Created attachment 7407 
thunar-archive-plugin.patch against GIT
Comment 3 Andre Miranda editbugs 2017-11-01 03:43:47 CET
Thanks for providing patches, but I think you overlooked my WIP repository:
https://github.com/andreldm/thunar-archive-plugin
Comment 4 Ali Akcaagac 2017-11-01 10:55:53 CET
Moin (german for hello)

I wasn't aware that there was a WIP repository outside of git.xfce.org. This would clearly have saved some time.

Background:

We have an automate (external) system running, that pulls in git.xfce.org every couple of days. This system generates release tarballs and compiles rpm's for Fedora.

We are not related to Fedora by the way. We only use the git.xfce.org to build test packages for our own demand and to stay on top of the edge.

This system only deals with git.xfce.org, the source archive, and separate patches... It's not cloning the git repository but rather downloads the master.tar.bz2 files generated for download. It's a KISS system.

A couple of days ago our system reported some --gtk-doc issue with thunarx-3 which (iirc) was provided inside Thunar. We were able to solve that issue on our side (by excluding the entire directory in the to be packaged rpm file).

Unfortunately thunar-archive and thunar-media-tags refused to build because of the API changes and the configure detecting mechanism. thunar-media-tags (the other bugreport your commented on), was an easy *trial and error' fix. We didn't test any further because we first wanted the stuff to compile again, so that our automate system stops complaining.

Same for the thunar-archive. We changed thunarx-2 to thunarx-3, removed the GTK_SEPARATOR line, changed tooltips to tooltip and the other change with the vbox I've copied over 1:1 from the thunar archive thunar-sent-to-email plugin (which required a similar change).

---> No further tests has been done.

Besides reporting some issues, we otoh are not really tied to XFCE development (yet). so we don't catch up on communications and other external structural changes (as I read some lines of the ML a couple of days ago).

It would really help, if the changes you made in github would be merged back to git.xfce.org master. That way things would be kept on a central repository rather than spread. This would also help third party systems (that rely on e.g. git.xfce.org) won't get messy after a while because things are spread everywhere.
Comment 5 Andre Miranda editbugs 2017-11-02 03:52:53 CET
Not my fault this time, the repository is linked on the roadmap page ;)

As I mentioned on the other bug, things will be fixed shortly, this is an exceptional situation. Please notice that I'm not Thunar's maintainer (probably this is the 1000th time I repeat that xD), I'm trying my best to not break things, that's why those changes were not merged yet.

As you seem interested in Continuous Integration, have a look at Xfce's Jenkins if you haven't yet:
http://buildbot.xfce.org

Perhaps you could help with that :)
Comment 6 Andre Miranda editbugs 2017-11-03 00:11:09 CET
I had some free time today, so I merged everything (thunarx-3 and archive-plugin changes) to master, please test and report any bug found.
Comment 7 Ali Akcaagac 2017-11-05 14:30:37 CET
Installs into /lib/thunarx-2 even with thunarx GIT which installs everything into /lib/thunarx-3
Comment 8 Ali Akcaagac 2017-11-05 17:23:10 CET
Please ignore my feedback before. There was an issue with one of our scripts causing the issue by overwriting the new master.tar.bz2 download with an old version. We fixed that issue on our side.

Your changes were all correct and working. Also correct installation.

Bug #13967

Reported by:
Ali Akcaagac
Reported on: 2017-10-31
Last modified on: 2017-11-05

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information