! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Typo in calculating NET_WORKAREA for bottom struts
Status:
RESOLVED: FIXED

Comments

Description Andrey Alekseenkov 2017-10-31 13:12:29 CET
Created attachment 7402 
patch fixing typo in calculating NET_WORKAREA for bottom struts

There is an typo when calculating NET_WORKAREA for L-shaped displays.
If panel is on bottom of the primary monitor NET_WORKAREA does not ignore struts on other displays.
It is typo because all others struts (left, right and top) works correct and in workspace.c we should use && instead || when checking STRUTS_BOTTOM.
I created a patch and put it here.
Comment 1 Git Bot editbugs 2017-12-06 09:56:01 CET
Andrey Alekseenkov referenced this bugreport in commit b6fa004ea1ad4d7db84730ae5f773cbc4b762eeb

Fix logic error in bottom struts validation

https://git.xfce.org/xfce/xfwm4/commit?id=b6fa004ea1ad4d7db84730ae5f773cbc4b762eeb
Comment 2 Git Bot editbugs 2018-07-27 22:35:18 CEST
Andrey Alekseenkov referenced this bugreport in commit 0f7f70f3b3ed0883bdca6989673dbd1cdffdd901

Fix logic error in bottom struts validation

https://git.xfce.org/xfce/xfwm4/commit?id=0f7f70f3b3ed0883bdca6989673dbd1cdffdd901

Bug #13964

Reported by:
Andrey Alekseenkov
Reported on: 2017-10-31
Last modified on: 2018-07-27

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Version:
4.12.0

Attachments

Additional information