! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
tumblerd crashes if $XDG_DATA_DIRS lists the same directory twice
Status:
RESOLVED: FIXED
Product:
Tumbler
Component:
General

Comments

Description David Korth 2017-06-03 05:58:25 CEST
If $XDG_DATA_DIRS lists the same directory twice, and that directory has at least one Specialized Thumbnailer .service file, tumblerd will crash with an assertion failure.

Tested using tumbler-0.1.31-2build2 on Xubuntu 16.04.

XDG_DATA_DIRS=/usr/share/xubuntu:/usr/share/xfce4:/usr/local/share/:/usr/share/:/var/lib/snapd/desktop:/usr/share

The assertion:

tumblerd:ERROR:tumbler-manager.c:1040:tumbler_manager_load_thumbnailer: assertion failed: (info2->dir_index != info->dir_index)

This bug seems to be present in git master. tumbler_manager_load() doesn't check for duplicate directories when building the list.
Comment 1 Ali Abdallah editbugs 2017-06-04 19:39:24 CEST
Thanks you very much for reporting this issue. I will be testing and applying a patch to solve this issue.
Comment 2 Ali Abdallah editbugs 2017-06-04 20:40:38 CEST
Created attachment 7157 
Avoid XDG_DATA_DIRS duplicates

Please could you try the attached path and report back.
Comment 3 David Korth 2017-06-05 04:20:50 CEST
Applied the patch to 0.1.31, and it fixes the assertion for me. Thanks.

Bug #13618

Reported by:
David Korth
Reported on: 2017-06-03
Last modified on: 2017-06-09

People

Assignee:
Ali Abdallah
CC List:
1 user

Version

Version:
unspecified

Attachments

Avoid XDG_DATA_DIRS duplicates (1.12 KB, patch)
2017-06-04 20:40 CEST , Ali Abdallah
no flags

Additional information