Created attachment 6914 The style property deprecated ... (mousepad:7559): Gtk-WARNING **: Theme parsing error: <data>:2:29: The style property GtkButton:default-border is deprecated and shouldn't be used anymore. It will be removed in a future version (mousepad:7559): Gtk-WARNING **: Theme parsing error: <data>:3:37: The style property GtkButton:default-outside-border is deprecated and shouldn't be used anymore. It will be removed in a future version (mousepad:7559): Gtk-WARNING **: Theme parsing error: <data>:4:27: The style property GtkButton:inner-border is deprecated and shouldn't be used anymore. It will be removed in a future version (mousepad:7559): Gtk-WARNING **: Theme parsing error: <data>:5:31: The style property GtkWidget:focus-line-width is deprecated and shouldn't be used anymore. It will be removed in a future version (mousepad:7559): Gtk-WARNING **: Theme parsing error: <data>:6:28: The style property GtkWidget:focus-padding is deprecated and shouldn't be used anymore. It will be removed in a future version ... As seen with GTK+ 3.20.9 and 3.22.4. $ mousepad --version Mousepad 0.4.0git-20160907gitedbe8b6 Copyright (c) 2007 The Xfce development team. All rights reserved. Please report bugs to <http://bugzilla.xfce.org/>.
To be clear, mousepad spews the above messages to the console (or spams the X session log with them) when it starts up. This is triggered by the hard-coded gtk3 styles in mousepad_close_button_class_init(), all of which are invalid in current versions of gtk3.
Created attachment 8312 Replace deprecated style properties in MousepadCloseButton I based my edits on the GTK documentation's recommendations: - GtkButton's default-border, default-outside-border, and inner-border properties are replaced with the padding property that was already present; even then, they currently are ignored. - GtkWidget's focus-line-width property is replaced with the already-present padding property and the added outline-width property. - GtkWidget's focus-padding property is replaced with the new outline-offset property. Links: - https://developer.gnome.org/gtk3/3.24/GtkButton.html#GtkButton--s-default-border - https://developer.gnome.org/gtk3/3.24/GtkButton.html#GtkButton--s-default-outside-border - https://developer.gnome.org/gtk3/3.24/GtkButton.html#GtkButton--s-inner-border - https://developer.gnome.org/gtk3/3.20/GtkWidget.html#GtkWidget--s-focus-line-width - https://developer.gnome.org/gtk3/3.20/GtkWidget.html#GtkWidget--s-focus-padding The button appears to look and function the same as it did before when using the "default" Greybird theme.
Comment on attachment 8312 Replace deprecated style properties in MousepadCloseButton (deleted since I somehow didn't see there was already a patch submitted, sorry)
Hunter Turcin referenced this bugreport in commit dc9e6b29e63423ac67fff4494b021f75fc520bd2 Replace deprecated style properties in MousepadCloseButton (Bug #13114) https://git.xfce.org/apps/mousepad/commit?id=dc9e6b29e63423ac67fff4494b021f75fc520bd2
(In reply to huntertur from comment #2) > Created attachment 8312 > Replace deprecated style properties in MousepadCloseButton Thanks for the patch, I went with it because the one provided by the reporter just removed all styling set for gtk3. I also pushed a follow-up commit: https://git.xfce.org/apps/mousepad/commit/?id=ffe5aebd0d4c90312a397c78001f07e55fce2823 I wonder if this class is really needed, anyway that's beyond this bug report.