! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
weather plugin build error on solaris 10 x86
Status:
RESOLVED: FIXED
Product:
Xfce4-weather-plugin
Component:
General

Comments

Description Courtney Spencer 2005-11-02 09:21:00 CET
xfce4 version 4.2.2.  When building on solaris 10 x86 from pkgsrc I 
receive compiler errors in function create_summary_tab and the build exits. 
  
  

Reproducible: Always
Steps to Reproduce:
1. cd pkgsrc/misc/xfce4-weather-plugin  
2. bmake  install 
3. after fixing the mixer plugin build as described in another forum,  
everything will build for xfce, except the weather plugin  
  
Actual Results:  
summary_window.c: In function `create_summary_tab': 
summary_window.c:25: error: syntax error before numeric constant 
summary_window.c:112: error: invalid lvalue in assignment 
summary_window.c:114: warning: pointer/integer type mismatch in conditional 
expression 
summary_window.c:116: warning: passing arg 1 of `g_free' makes pointer from 
integer without a cast 
summary_window.c:120: error: invalid lvalue in assignment 
summary_window.c:122: warning: pointer/integer type mismatch in conditional 
expression 
summary_window.c:124: warning: passing arg 1 of `g_free' makes pointer from 
integer without a cast 
summary_window.c:130: error: `vis' undeclared (first use in this function) 
summary_window.c:130: error: (Each undeclared identifier is reported only once 
summary_window.c:130: error: for each function it appears in.) 
gmake: *** [libweather_la-summary_window.lo] Error 1 
 

Expected Results:  
The plugin should have been built and installed  

Here is the link to the xfce forum post, where others are having similar   
issues with building on solaris/solaris (sparc).  There is a listed  
fix that works for the mixer plugin and allows compilation to continue until  
you get to the weather plugin, for which, I've found no fix.  
  
http://www.os-cillation.de/cgi-bin/yabb/YaBB.cgi?board=Help;action=display;num=1109782807  
 
You can see that I receive the same error in the weather plugin as another user 
two xfce versions ago and several lines have been added to summary_window.c 
since then. 
  
  
# gcc -v    
Reading specs from /usr/sfw/lib/gcc/i386-pc-solaris2.10/3.4.3/specs    
Configured with: /builds/sfw10-gate/usr/src/cmd/gcc/gcc-3.4.3/configure    
--prefix=/usr/sfw --with-as=/usr/sfw/bin/gas --with-gnu-as    
--with-ld=/usr/ccs/bin/ld --without-gnu-ld --enable-languages=c,c++    
--enable-shared    
Thread model: posix    
gcc version 3.4.3 (csl-sol210-3_4-branch+sol_rpath)    
    
--    
GNU Make 3.80    
--
Comment 1 Bob Schl 2005-11-02 15:29:50 CET
Created attachment 334 
Patch to fix this
Comment 2 Bob Schl 2005-11-02 15:30:36 CET
It seems that a header is included which defines the a symbolic constant named
"sun". As the code tries to declare a variable named "sun" it obviously doesn't
work.
The attached patch should fix this by changing the name of the variable used.
Apply with path -p0 < sun_patch.diff
Comment 3 Nobodys Account 2005-11-02 17:03:23 CET
Thanks
I appilied your patch to panel-plugin/summary_window.c
This fixed the issue and the build completed smoothly
Comment 4 Nick Schermer editbugs 2006-08-03 20:31:16 CEST
A bit late... but it's fixed in trunk. Thanks for the patch.
Comment 5 Jannis Pohlmann editbugs 2009-06-12 13:21:33 CEST
Re-assigning to Colin Leroy who is the new maintainer of the plugin.

Bug #1206

Reported by:
Courtney Spencer
Reported on: 2005-11-02
Last modified on: 2014-12-07

People

Assignee:
Colin Leroy
CC List:
1 user

Version

Version:
0.7.3 or older

Attachments

Patch to fix this (920 bytes, patch)
2005-11-02 15:29 CET , Bob Schl
no flags

Additional information