! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
build failure on x32: #include <sys/sysctl.h>
Status:
RESOLVED: FIXED
Product:
Xfce4-netload-plugin
Component:
General

Comments

Description Adam Borowski 2015-01-24 22:11:40 CET
Created attachment 5878 
patch dropping the bad #include

Building the plugin fails with:
/usr/include/x86_64-linux-gnux32/bits/sysctl.h:19:3: error: #error "sysctl system call is unsupported in x32 kernel"

This include is useless and can be removed.  This syscall has been strongly deprecated for ages and the plugin doesn't use it any more.  On old architectures, this include is benign as long as it's unused, on new ones (such as x32) it results in a build failure.

Trivial patch attached.
Comment 1 Steve Dodier-Lazaro editbugs 2015-02-08 20:40:17 CET
The patch does not cause any regression for me on ArchLinux amd64 3.18.

Bumping urgency as it concerns a build failure. Could people on old Debians test and tell if a regression occurs?

Relevant: http://man7.org/linux/man-pages/man2/sysctl.2.html
Comment 3 Skunnyk editbugs 2017-06-09 17:37:25 CEST
Closing.
Comment 4 Git Bot editbugs 2017-11-02 23:05:50 CET
Adam Borowski referenced this bugreport in commit 3c9496434768e9a23c88bc1bf2b4eaaf689c7cef

Remove sys/sysctl.h on linux platform

https://git.xfce.org/panel-plugins/xfce4-netload-plugin/commit?id=3c9496434768e9a23c88bc1bf2b4eaaf689c7cef
Comment 5 Skunnyk editbugs 2017-11-02 23:17:54 CET
The last gitbot message was a mistake, please ignore.

Bug #11477

Reported by:
Adam Borowski
Reported on: 2015-01-24
Last modified on: 2017-11-02

People

Assignee:
Skunnyk
CC List:
2 users

Version

Version:
unspecified

Attachments

patch dropping the bad #include (312 bytes, patch)
2015-01-24 22:11 CET , Adam Borowski
no flags

Additional information