! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Wrong selection color in icon chooser


Description Manuel Grießmayr 2018-12-12 23:02:22 CET
Created attachment 8177 
Selected item

The color of selected items in the icon chooser won't change with other themes. The label will always be red and the icons will be black. I think it would be better when the icons have a semi transparent overlay color so that somebody still can see the details of an icon and not only the outline. The overlay and label color should be according to the selection color of the current theme. Please also have a look at the attached screenshot.

My system is Xubuntu 18.10 64 bit and I tested this with exo 0.12.3.
Comment 1 Skunnyk editbugs 2019-01-02 23:28:58 CET
I confirm, I can reproduce the problem with Adwaita and Greybird, with exo-desktop-item-edit
Comment 2 Git Bot editbugs 2019-01-11 04:13:58 CET
Sean Davis referenced this bugreport in commit c551d0857e0595abb45d118d7c289fe57a44bf14

Replace ExoCellRendererIcon with GtkCellRendererPixbuf to improve the icon chooser appearance (bug #14971)

Comment 3 Sean Davis editbugs 2019-01-11 04:15:12 CET
I was able to reproduce this bug and the above commit seems to resolve it. Marking this bug resolved, but please reopen if the issue if you are still seeing issues.
Comment 4 Manuel Grießmayr 2019-01-11 15:23:38 CET
Hmmmm... I cannot see any changes in the gui. But maybe I am too stupid.

I downloaded the latest exo release, applied your patch with "git apply", compiled and installed. Then I recompiled and reinstalled xfce-panel (the makefile is using the exo lib under /usr/local/lib). After that I restarted my user session and tried to change an icon in the panel bar but the icon chooser hasn't changed.
Comment 5 Manuel Grießmayr 2019-01-11 15:37:46 CET
But wait there is a change :)

The background color of the label (the name of an icon) now changes with different themes. But the icons and their selection color haven't changed. With the Numix theme for example the icon selection color should be red with some transparency and not black without transparency.
Comment 6 Sean Davis editbugs 2019-01-12 12:12:16 CET
It might still be using the library installed in /usr, `ldconfig` sometimes addresses this. To easily test this patch, make exo then run exo-desktop-item-edit from the source directory

./exo-desktop-item-edit/exo-desktop-item-edit /usr/share/applications/firefox.desktop

You should see the familiar edit launcher window, and clicking the icon will take you to the icon browser.
Comment 7 Manuel Grießmayr 2019-01-12 15:23:37 CET
With your directions there is no selection color on the icon anymore regardless which theme is selected but the label is drawn correctly. This is better than before but it isn't consistent behaviour system wide. For example selections in Thunar or on the desktop or within the icon chooser should look identical. Thunar makes everything right in this regard. With the Numix theme selected lables/filenames have a red background and the icons have a red overlay with some transparency. For Xfdesktop I was able to achieve the same look with some GTK-CSS customizations (https://forum.xfce.org/viewtopic.php?pid=50526#p50526).
Comment 8 Sean Davis editbugs 2019-01-19 03:39:50 CET
This issue should now be permanently resolved. The below commit takes Exo back to the ExoCellRendererIcon and fixes the color masking. Swapping between themes also seems to change the highlight color on the text and the icon.

Comment 9 Manuel Grießmayr 2019-01-19 11:27:14 CET
Many thanks for the patch. This shit is working like a charm :)

It's not working with this method:
./exo-desktop-item-edit/exo-desktop-item-edit /usr/share/applications/firefox.desktop
but when I install it locally.

I also got some nice help in the XFCE forum:

Bug #14971

Reported by:
Manuel Grießmayr
Reported on: 2018-12-12
Last modified on: 2019-01-19


Nick Schermer
CC List:
4 users



Selected item (116.41 KB, image/png)
2018-12-12 23:02 CET , Manuel Grießmayr
no flags

Additional information