Created attachment 8045
Icons within tooltips
The tooltips of starters in the panel have too small or too big icons in some cases. Please have a look at the screenshot attached. I am using the numix theme with elementary xfce dark symbols but it doesn't matter which theme or symbols I use.
I have Xubuntu 64 bit x86 version 18.10. Since I upgraded from Xubuntu version 18.04 to 18.10 I have this issue.
XFCE4 version 4.13.3 , the launcher plugin, compiled to link to libgtk-3
I have something similar -- default size for xfce4 panel launcher is documented as "32x32" (https://docs.xfce.org/xfce/xfce4-panel/launcher) but I'm getting 16x16. The method decribed on that webpage are inscrutable. "in gtk-icon-sizes" where? the gtkrc ? in gconf ? In some other database/ keystore/ ini-file/ env-file ? The accompanying instructions for theming in https://docs.xfce.org/xfce/xfce4-panel/theming don't mention "gtk-icon-sizes".
denyer suggested looking in ~/.config/gtk-3.0/settings.ini instead, but supposes that "gtk-icon-sizes" was removed from that ini-file. Tried adding "gtk-icon-sizes=panel-launcher-menu=32,32:panel-launcher-tooltip=32,32" to the "[Settings]" section, as if it were gconf or gtkrc, but no dice.
Created attachment 8055
sample of panel launcher tooltip icon size
Notice that the launcher tooltip icons are SMALLER than the panel & launcher icons themselves.
Created attachment 8058
One can easily reproduce this bug:
Create a .png file with size 128 x 128 pixels in the folder /home/user/.local/share/icons/hicolor/128x128/apps. Then create a .desktop file under /home/user/.local/share/applications where you set the icon to the .png file you just created. Log out and back in so the application menu reloads. The icon in the application menu will not be resized and will be visible in full size with 128 pixels width and height. If you create a starter in a panel with the PNG file just created as an icon we will have the same effect. The icon in the tooltip of the starter is way too big. So this is not only an issue of panel starters but also an issue in the application menu.
Created attachment 8107
Icons in wrong size
@Manuel, are you able to check if my patch solves this?
Ok, this bugreport confuses some things.
1) Items in applications menu (size). Has been fixed (but not yet released) in garcon: https://git.xfce.org/xfce/garcon/commit/?id=4387496fe332a50945e7db76bc2196b419656fe3
2) Tooltip icons in the panel's launcher plugin.
I'm not sure I can actually reproduce 2).
@Andre: Can you?
Yes, #1 is a garcon issue, fixed long ago in git master, surprisingly not released yet!
And my patch is to fix #2, which I was able to reproduce, but not anymore, probably panel is patched here, too lazy to check.
Simon Steinbeiss referenced this bugreport in commit 3cdf2a44751823752cf62da58ce4c03aa283bd3d
launcher: Fix tooltip icon size (Bug #14774)
I actually took some time and managed to reproduce the problem today.
Applied the fix (which still works) - thanks again for the patch!
Cool, many thanks for the patch :)
One more thing. I also have this problem with the context menu on the desktop. The Thunar context menu is not affected. Let me know when I should open a bug for it. Please have a look at the screenshot below.
Created attachment 8118
It's the submenu "Open with" in the context menu.
That one is very likely the same (garcon) as mentioned above - so fixed already with garcon >0.6.1
I have tested this patch and can confirm that the tooltip icons for starters are fine now.
I also tested the patch for garcon but without success. I compiled the patched xfce4-panel with the patched garcon lib. Garcon via the ubuntu repository is not installed. Don't know, maybe I have overlooked something...
So my application menu and context menu still have too big icons.
Andre Miranda referenced this bugreport in commit 8f2a3f2e19e77ac329ed9d1ed0d7b98311999038
Fix icon size in Open with submenu (Bug #14774)
Great, context menu is fine now too with the patch from Comment 17.
I am sorry for reopening this bug but I found another issue. The patch isn't working with .svg files.
To be honest I'm afraid that Gtk+ (or: GdkPixbuf) is at fault here and I'm not sure we can do much more. The call to get the pixbuf gdk_pixbuf_new_from_file_at_size/scale should really return the icon in the requested size, but instead we get a 5x5 icon.
Anyway, I'll investigate a little and see...
Maybe we should open a bug in the Gtk+ Bugtracker?
I also have the following behaviour with my Audacious program in the panel bar. When I select the audacious icon from the list in the symbol chooser under drop down item "application symbols" (translated from German) then the icon looks fine in the tooltip. But when I select "picture files" (translated from German) from the drop down in the symbol chooser and browse for an icon manually in the file system then the icons in the tooltip have the wrong size. I tested the last case with .svg and .png files:
So the problem maybe has nothing to do with .svg files but instead the way the user selected the icon. Of course I also tested this with other programs than audacious.
Strangely on the panel itself (not the tooltip icon) the audacious icon has been cut. The first horizontal pixel line and the last are not visible. This is only the case for the audacious icon. All other icons are fine. And the icon is only truncated when the height of the panel bar has an even number. For uneven numbers the icon is fully visible. I know this is nit-picky but wanted to document this behaviour.
I did some further tests. The cropped audacious icon is a general problem. So I created this bug: https://bugzilla.xfce.org/show_bug.cgi?id=14958
@Manuel: To be honest I've lost track of this issue a bit. Is what you originally reported resolved now? (The related bug seems different from what you initially reported, at least if I understood you correctly.)
Using xfce 4.13.4 now (packaged in Ubuntu 19.04, linked to GTK3).
Launcher icons are still smaller than I expected, but they are a consistent size now.
With the latest xfce panel version 4.13.4 the icons look fine now but comment 22 is still true and a bug.
Strangely now that I am testing this again I cannot change the icons again because the "Properties..." menu entry is greyed out in the context menu of the panel starter. This is really weird :/
Please ignore the last paragraph it was my fault. The "Properties..." menu entry isn't greyed out.
@Manuel: Ok, it seems there are multiple bugreports in this one single report. Would you mind if we close this - already confusing and long - report in favor of a new and clean report so people starting to read it don't have to spend lots of time to get to the bottom?
Okilidokili, here we go: