! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
More suitable bookmark icon


Description Manuel Grießmayr 2018-02-24 16:43:08 CET
Created attachment 7616 
Patch for icon change

I suggest a more suitable bookmark icon for .desktop files. The new icon has no plus sign. Please have a look at the patch attached.
Comment 1 Simon Steinbeiss editbugs 2018-02-27 22:38:47 CET
The patch makes sense from my pov (especially when you compare the two Adwaita icons).
Comment 2 Manuel Grießmayr 2018-02-28 21:43:06 CET
In the past we had the icon "gnome-fs-bookmark" which I think is still the most suitable icon available when I compare the available themes on my Xubuntu 17.10 machine. But this icon has been dropped according to the change log:

    commit 24a27170604dba7c9e518ce6d0884bb0b5fe819b
    Author: Sean Davis <smd.seandavis@gmail.com>
    Date:   Sun Jul 2 20:14:49 2017 -0400

    Drop non-standard gnome-fs-bookmark and gnome-mime-application-x-executable icons

    commit 199534217cfc30c342ea6d881ffebf72ad9d45b0
    Author: Sean Davis <smd.seandavis@gmail.com>
    Date:   Sun Jul 2 19:47:55 2017 -0400

    Drop non-standard gnome-fs-* icons

The icon "user-bookmarks" seems to be for a button to list all bookmarks. This icon looks fine with most themes but on Adwaita and Gnome theme we have a directory symbol with a star.

The "bookmark-new" icon seems to be for a button to create new bookmarks and not for an existing bookmark. This explains the plus sign.
Comment 3 Git Bot editbugs 2018-06-06 12:46:18 CEST
Manuel Grießmayr referenced this bugreport in commit eb01d3b550d5a8d180e61bdab26029e91beff4d9

Use user-bookmarks instead of bookmark-new for the bookmark icon (bug 14243)

Comment 4 Sean Davis editbugs 2018-06-06 12:46:48 CEST
Thanks for the patch! Applied above.

Bug #14243

Reported by:
Manuel Grießmayr
Reported on: 2018-02-24
Last modified on: 2018-06-06


Nick Schermer
CC List:
3 users



Patch for icon change (734 bytes, patch)
2018-02-24 16:43 CET , Manuel Grießmayr
no flags

Additional information