Since I often open Thunar by double clicking folders on the desktop or by launching it from the command line I quickly end up with a bunch of Thunar windows that clutter my taskbar and are cumbersome to manage. I really miss an "open new windows as tabs" feature.
Created attachment 7887 patch1 Thanks for reporting and sorry for the very late reply ! In compensation for your long waiting time, attached a patch which implements the feature :)
Created attachment 7888 patch2 The second patch will make the "behavior" menu look a bit better .. however it will require translators to re-translate some strings. IMO we can apply both patches to master and the 4.14 branch, since these strings on menu page 3 are not that prominent. I kept the second patch as separate commit, just in case there is a opposite opinion on that ... I can squash it, if not.
Created attachment 7889 patch 1 improved patch1 - bring thunar window to front if it is hidden - use topmost thunar-window for new tab
Created attachment 7890 all in one patch Like decided on irc, we will apply both on master and 4.14. So no need to split
Works great to here. My remarks: - forceNewWindow, shouldn't this be snake_case? - "Open Tabs instead of new Windows" -> "Tabs instead of new Windows"? - A checkbox instead of two radio buttons was a great idea - new tabs are opened in the last focused window, not the last created. Is this the expected behavior? Other than that, LGTM, thanks and congrats!
Alexander Schwinn referenced this bugreport in commit 88af16bddf6f292adadf446fa8f6226a41524167 Add preference to open new thunar instances as tabs, if there is an existing thunar window (Bug #13314) https://git.xfce.org/xfce/thunar/commit?id=88af16bddf6f292adadf446fa8f6226a41524167
Alexander Schwinn referenced this bugreport in commit 8dd1c609ff730e2a141c5ebd66fe42b9f72eb19f Add preference to open new thunar instances as tabs, if there is an existing thunar window (Bug #13314) https://git.xfce.org/xfce/thunar/commit?id=8dd1c609ff730e2a141c5ebd66fe42b9f72eb19f
Valid points, thanks! Fixed everything like proposed and pushed to master and 4.14