! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add preference to open in new tab by default


Description larivact 2017-01-28 10:46:53 CET
Since I often open Thunar by double clicking folders on the desktop or by launching it from the command line I quickly end up with a bunch of Thunar windows that clutter my taskbar and are cumbersome to manage.
I really miss an "open new windows as tabs" feature.
Comment 1 alexxcons editbugs 2018-08-17 22:17:57 CEST
Created attachment 7887 

Thanks for reporting and sorry for the very late reply !

In compensation for your long waiting time, attached a patch which implements the feature :)
Comment 2 alexxcons editbugs 2018-08-17 22:23:33 CEST
Created attachment 7888 

The second patch will make the "behavior" menu look a bit better .. however it will require translators to re-translate some strings.

IMO we can apply both patches to master and the 4.14 branch, since these strings on menu page 3 are not that prominent.

I kept the second patch as separate commit, just in case there is a opposite opinion on that ... I can squash it, if not.
Comment 3 alexxcons editbugs 2018-08-17 23:05:59 CEST
Created attachment 7889 
patch 1

improved patch1
- bring thunar window to front if it is hidden
- use topmost thunar-window for new tab
Comment 4 alexxcons editbugs 2018-08-18 06:58:59 CEST
Created attachment 7890 
all in one patch

Like decided on irc, we will apply both on master and 4.14. So no need to split
Comment 5 Andre Miranda editbugs 2018-08-19 06:05:06 CEST
Works great to here. My remarks:
- forceNewWindow, shouldn't this be snake_case?
- "Open Tabs instead of new Windows" -> "Tabs instead of new Windows"?
- A checkbox instead of two radio buttons was a great idea
- new tabs are opened in the last focused window, not the last created. Is this the expected behavior?

Other than that, LGTM, thanks and congrats!
Comment 6 Git Bot editbugs 2018-08-20 13:39:56 CEST
Alexander Schwinn referenced this bugreport in commit 88af16bddf6f292adadf446fa8f6226a41524167

Add preference to open new thunar instances as tabs, if there is an existing thunar window (Bug #13314)

Comment 7 Git Bot editbugs 2018-08-20 13:44:23 CEST
Alexander Schwinn referenced this bugreport in commit 8dd1c609ff730e2a141c5ebd66fe42b9f72eb19f

Add preference to open new thunar instances as tabs, if there is an existing thunar window (Bug #13314)

Comment 8 alexxcons editbugs 2018-08-20 13:46:07 CEST
Valid points, thanks!

Fixed everything like proposed and pushed to master and 4.14

Bug #13314

Reported by:
Reported on: 2017-01-28
Last modified on: 2018-08-20


CC List:
4 users




patch1 (16.56 KB, patch)
2018-08-17 22:17 CEST , alexxcons
no flags
patch2 (16.56 KB, patch)
2018-08-17 22:23 CEST , alexxcons
no flags
patch 1 (16.56 KB, patch)
2018-08-17 23:05 CEST , alexxcons
no flags
all in one patch (16.41 KB, patch)
2018-08-18 06:58 CEST , alexxcons
no flags

Additional information