! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
netload plugin doesnt pickup gtk theme colors
Status:
CLOSED: FIXED
Severity:
enhancement
Product:
Xfce4-netload-plugin
Component:
General

Comments

Description Yves-Alexis Perez editbugs 2006-06-03 11:51:07 CEST
Netload plugin doesnt pickup color from the gtk theme, as other *load, battery and mixer plugin do. You can chose the color but don't have the choice to pickup the gtk theme specified color.

It would be nice to have gtk color support in this plugin.

Regards,

Yves-Alexis Perez
Comment 1 Bernhard Walle 2006-12-17 21:50:57 CET
Systemload plugin has the same problem. AFAIK it depends on the Gtk theme whether it works. Don't know how to fix this. Can you help?
Comment 2 Harold Aling 2007-09-23 20:26:57 CEST
Is this supported in the current version?
Comment 3 Brian J. Tarricone (not reading bugmail) 2007-10-04 07:04:12 CEST
Created attachment 1384 
netload-fix-bar-colors.diff

Patch to fix bar colors.  It looks like some themes use different colors and states to paint the progress bar.  This patch makes it set all three of the ones I'm aware of - bg[PRELIGHT], bg[SELECTED], and base[SELECTED].

The patch also removes the GtkRcStyle code used to set the colors in favor of the simpler gtk_widget_modify_bg() and gtk_widget_modify_base() convenience functions.  Works for me here on ClearLooks, which just shows the default blue theme color without this patch.

(I've attached a similar patch to a bug for systemload as well.)
Comment 4 Yves-Alexis Perez editbugs 2008-01-13 22:19:33 CET
This bug seems to be solved, at least in 0.4
Comment 5 Brian J. Tarricone (not reading bugmail) 2008-01-13 23:35:31 CET
No, it's not.
Comment 6 Yves-Alexis Perez editbugs 2008-01-14 06:50:52 CET
Hmmh, here netload plugin correctly picks gtk theme color (using murrine engine).
Comment 7 Brian J. Tarricone (not reading bugmail) 2008-01-14 07:31:03 CET
Clearlooks doesn't work, netload svn trunk from 10 hours ago or so.
Comment 8 Yves-Alexis Perez editbugs 2008-01-14 07:38:31 CET
Using clearlooks 2.12.2 it works here. How strange.
Comment 9 Brian J. Tarricone (not reading bugmail) 2008-01-14 08:11:12 CET
2.12.2 here as well.  Very strange.
Comment 10 Christoph Wickert editbugs 2009-06-13 17:10:43 CEST
xfce4-netload-plugin-0.4.0 picks up the theme colors here with gtk2 2.14.7, but this brakes the custom colors set in the plugin preferences.

Clearlooks: fail
Crux: ok
Glider: fail
Glossy: fail
High Contrast: ok
Industrial: ok
Inverted: ok
Large Print: ok
Low Contrast: ok
Mist: ok
Nimbus: fail
Nodoka: fail
Raleigh: ok
Simple: ok
Sugar: fail (somehow intented)
Thin Ice: ok
Xfce: ok

Reported as https://bugzilla.redhat.com/show_bug.cgi?id=505214
Comment 11 PC2st.ir 2009-06-14 15:20:37 CEST
Unfortunately, netload-plugin background color is not related to panel background color. systemload-plugin has the same problem too. It's not differ witch color i used for my panel background color. Therefore it's not possible to use some of the great themes.
Comment 12 Florian Rivoal editbugs 2010-11-05 15:25:39 CET
Patch applied. It should work fine now.

Bug #1889

Reported by:
Yves-Alexis Perez
Reported on: 2006-06-03
Last modified on: 2012-01-13

People

Assignee:
Florian Rivoal
CC List:
6 users

Version

Version:
0.4.0 or older

Attachments

netload-fix-bar-colors.diff (3.60 KB, patch)
2007-10-04 07:04 CEST , Brian J. Tarricone (not reading bugmail)
no flags

Additional information