! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Please bring back the tray icon
Status:
RESOLVED: FIXED
Product:
Xfce4-power-manager
Component:
General

Comments

Description Roland Hieber 2014-07-29 01:08:05 CEST
Citing the 1.3.0 release announcement from https://mail.xfce.org/pipermail/xfce-announce/2014-June/000326.html:
>   One of the most noticable changes to xfpm is a new panel plugin
> to monitor battery and device charge levels which replaces the
> trayicon. If anyone outside of Xfce was using xfce4-power-manager
> in a different panel, such as LXDE, and wants xfpm to continue to
> work there, request it in bugzilla and we'll work on it.

I'm using xfpm with awesome, which worked fine for me, mostly because xfpm does not require any sort of desktop session running (like gnome-power-manager), and because since 1.3.0 it also supports systemd/logind instead of console-kit. However, awesome cannot handle XFCE panel plugins, so it would be nice to get the old tray icon back, which worked fine. After all, the old tray icon code should not have changed much, no? ;-)

Thanks for looking into this.
Comment 1 Gaudenz Steinlin 2014-08-10 14:11:34 CEST
I'm too using xfce4-power-manager with the awesome window manager and just wanted to raise my support for this request. Is there anything I could do to get the functionality back? Would patches be considered?

Thanks Gaudenz
Comment 2 Eric Koegel editbugs 2014-08-14 18:29:30 CEST
Roland,
  Well the old tray icon was running into issues since UPower started adding battery icons for things other than UPS/Laptop batteries. You could end up with multiple tray icons (I only had 2 icons but if you had a wireless mouse, keyboard, and ipod you could easily hit 4). The panel plugin allowed us to separate some of the code out of the daemon, which was nice. However, adding the systray back shouldn't be too hard.

Gaudenz,
  Patches would happily be accepted! If you need help with it, you can ask questions here, e-mail me directly, or ask in #xfce-dev on freenode IRC (and idle for hours until one of us is around to help :). You can also post code to github and we can comment/help there if it helps.
  If you don't get time, let me know and I'll try to make time for it when I get a chance.
Comment 3 Eric Koegel editbugs 2014-09-01 14:45:21 CEST
FYI, there's a bounty on this bug now https://www.bountysource.com/issues/3392535-please-bring-back-the-tray-icon
Comment 4 Martijn Boers 2014-09-05 18:21:12 CEST
Using Chrunbang with Tint2, I too would like this functionality to come back. Any news on this?
Comment 5 Raphael Groner 2014-09-07 17:39:18 CEST
xfce4-power-manager 1.3.2
upower 0.9.23

There's no icon when battery is not available (physically removed, and booted with only AC plugged). Though, I use a wireless mouse.

(In reply to Eric Koegel from comment #2)
> Roland,
>   Well the old tray icon was running into issues since UPower started adding
> battery icons for things other than UPS/Laptop batteries. You could end up
> with multiple tray icons (I only had 2 icons but if you had a wireless
> mouse, keyboard, and ipod you could easily hit 4). The panel plugin allowed
> us to separate some of the code out of the daemon, which was nice. However,
> adding the systray back shouldn't be too hard.

Vote to show at least one icon, always independently if there's a known battery or not. How else could the user know if xfpm is running and easily access all plugin settings, e.g. the new brightness bar? Not sure about any sense for showing more than one icon. The single icon should say if battery or AC is active.
Comment 6 Raphael Groner 2014-09-11 23:34:16 CEST
See also bug #10327 for reasons.
Comment 7 Martijn Boers 2014-09-16 00:43:05 CEST
I've been using this:
https://github.com/decayofmind/tidybattery

Along with xfce4-power-manager. This way I can use my function keys for brightness and still get a sense of my battery life. Still hoping this will be fixed
Comment 8 Raphael Groner 2014-09-16 10:44:15 CEST
(In reply to Martijn Boers from comment #7)
> I've been using this:
> https://github.com/decayofmind/tidybattery

Okay, let's talk about different battery icon plugins, but this bug isn't the right place IMHO.

Why don't you use xfce4-battery-plugin then? It's officially part of the xfce goodies.

Further, there is batti to suggest, if you like to have the icon inside the systray: https://code.google.com/p/batti-gtk/
Comment 9 Martijn Boers 2014-09-16 11:00:02 CEST
(In reply to Raphael Groner from comment #8)
> (In reply to Martijn Boers from comment #7)
> > I've been using this:
> > https://github.com/decayofmind/tidybattery
> 
> Okay, let's talk about different battery icon plugins, but this bug isn't
> the right place IMHO.
> 
> Why don't you use xfce4-battery-plugin then? It's officially part of the
> xfce goodies.
> 
> Further, there is batti to suggest, if you like to have the icon inside the
> systray: https://code.google.com/p/batti-gtk/

Agreed, this isn't the right place. I'm not using xfce4-battery-plugin because of some uninstallable dependencies.
Comment 10 Julien [nodiscc] editbugs 2014-10-22 19:00:04 CEST
I too am a happy user of xfce4-power-manager (few dependencies, lightweight enough for my old laptop) on Debian with Openbox/tint2. I would like to see a tray icon again. There is alternative software, but then I miss the integration with xfpm (right-click menu) and I'd like to avoid installing yet another package for this.

Thanks to anyone who's working on this.
Comment 11 Simon Steinbeiss editbugs 2015-01-16 18:17:27 CET
*** Bug 11418 has been marked as a duplicate of this bug. ***
Comment 12 Eric Koegel editbugs 2015-02-16 16:12:25 CET
Created attachment 5946 
0001-Bring-back-the-tray-icon-Bug-11054

This patch uses the PowerManagerButton to implement the tray icon.
The option currently isn't shown in the settings dialog, but
everything else is in place. The xfconf property is:
/xfce4-power-manager/show-tray-icon
a value of 1 enables it, 0 disables it. It doesn't do the show
when (dis)charging stuff since it will display different battery
types now, however that can be added back if desired.

Testers/feedback appreciated. I didn't know where to place the show systray checkbox should be, but it's a trivial addition.
Comment 13 Eric Koegel editbugs 2015-02-16 16:20:01 CET
http://i.imgur.com/BF3pDD8.png
screenshot of the systray with right-click popup, the icon
on the far right is the xfce plugin version.
Comment 14 Konstantin Svist 2015-02-16 22:50:22 CET
Somewhat related question -- old systray used to include Suspend and Hibernate options; new panel/systray doesn't... will that ever come back?
Comment 15 Steve Dodier-Lazaro editbugs 2015-02-17 17:15:50 CET
Konstantin,

I don't think that was the right place for these settings. There are more adapted ones.
Comment 16 Eric Koegel editbugs 2015-02-22 11:50:20 CET
Created attachment 5979 
Bring back the tray icon

Version 2 of this patch. This adds an option to the
settings dialog because I got tired of typing out
the xfconf query or firing up the settings editor.
Additionally, the power manager button now removes
any sources attached to the battery devices when
the power manager button is removed. Before this
wasn't an issue since it meant the plugin was being
removed.
Comment 17 Eric Koegel editbugs 2015-03-01 20:48:42 CET
Pushed to master in:
commit 041f110b875ad854b3792d1a101d87c0ac271ad1
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Sun Feb 22 13:32:34 2015 +0300

    Bring back the tray icon (Bug #11054)
    
    This patch uses the PowerManagerButton to implement the tray icon.
    It doesn't do the show when (dis)charging stuff since it will
    display different battery types now, however that can be added
    back if desired.

http://git.xfce.org/xfce/xfce4-power-manager/commit/?id=041f110b875ad854b3792d1a101d87c0ac271ad1

Bug #11054

Reported by:
Roland Hieber
Reported on: 2014-07-29
Last modified on: 2015-03-01
Duplicates (1):

People

Assignee:
Ali Abdallah
CC List:
8 users

Version

Version:
Unspecified

Attachments

0001-Bring-back-the-tray-icon-Bug-11054 (18.29 KB, patch)
2015-02-16 16:12 CET , Eric Koegel
no flags
Bring back the tray icon (24.18 KB, patch)
2015-02-22 11:50 CET , Eric Koegel
no flags

Additional information